Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11](backport #3590) Remove PGP signature verification skip for DEV builds #3638

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 19, 2023

This is an automatic backport of pull request #3590 done by Mergify.
Cherry-pick of e43be2a


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner October 19, 2023 17:59
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 19, 2023
@mergify mergify bot requested review from AndersonQ and michalpristas and removed request for a team October 19, 2023 17:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-23T15:29:18.086+0000

  • Duration: 27 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 6485
Skipped 59
Total 6544

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor Author

mergify bot commented Oct 23, 2023

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

@AndersonQ AndersonQ force-pushed the mergify/bp/8.11/pr-3590 branch from a8e080d to 3007673 Compare October 23, 2023 14:42
* remove PGP signature verification skip for DEV builds
* create pgptest package to sign and give the public key to verify the signature
* fix tests that relied on skipping the PGP verification
* add PGP/GPG how-to on docs
* add test for VerifySHA512HashWithCleanup

(cherry picked from commit e43be2a)
@AndersonQ AndersonQ force-pushed the mergify/bp/8.11/pr-3590 branch from 3007673 to 13029c1 Compare October 23, 2023 15:28
@elastic-sonarqube
Copy link

@AndersonQ AndersonQ removed the request for review from michalpristas October 23, 2023 15:42
@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.81% (83/84) 👍
Files 66.556% (201/302) 👍
Classes 65.357% (366/560) 👍
Methods 53.003% (1165/2198) 👍 0.155
Lines 39.25% (13536/34487) 👍 0.086
Conditionals 100.0% (0/0) 💚

@AndersonQ
Copy link
Member

talking to @cmacknz we agreed it does not need to be backported

@AndersonQ AndersonQ closed this Oct 25, 2023
@mergify mergify bot deleted the mergify/bp/8.11/pr-3590 branch October 25, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants